Add write to disk options for build command #12006
Conversation
github-actions
bot
added
DEV: tools
Build Artifacts
|
packages/kolibri-tools/lib/cli.js
Outdated
| ); | ||
| runWebpackBuild(mode, bundleData, false, { | ||
| ...options, | ||
| cache: false, |
There was a problem hiding this comment.
Is there a reason not to utilize the webpack cache here? It should help with build performance either way.
Also, the use of hot is limited to the devserver being active, which we are passing false for, so I think this if could do the warn, then we could update the runWebpackBuild to simply be:
runWebpackBuild(mode, bundleData, !options.writeToDisk && mode === modes.DEV, options);
and not have to invoke it separately in the if statement.
There was a problem hiding this comment.
yes, I thought cache will fill the dev's system
There was a problem hiding this comment.
So yes, if hot and cache are not being modified then i will run the webpack build with your suggestions. Thank You
There was a problem hiding this comment.
The cache is better managed than the writing built files to disk, so I wouldn't worry too much!
Summary
This exposes
--write-to-diskflag in build that writes file to disk instead of webpackReferences
Fixes #4826
Reviewer guidance
In https://github.com/learningequality/kolibri/blob/develop/package.json#L15 Should there be a
prodargument?Testing checklist
PR process
Reviewer checklist
yarnandpip)